Don't ignore secure field on devfile endpoints #22676
Labels
area/che-operator
Issues and PRs related to Eclipse Che Kubernetes Operator
kind/enhancement
A feature request - must adhere to the feature request template.
lifecycle/frozen
Indicates that an issue or PR should not be auto-closed due to staleness.
severity/P1
Has a major impact to usage or development of the system.
team/A
This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Is your enhancement related to a problem? Please describe
Currently, setting
secure: true
on an endpoint does not add authentication to that endpoint, despite the devfile API documentation statingThis means the field is misleading, as setting it true or false doesn't change anything with respect to auth.
Describe the solution you'd like
As suggested by @l0rd in issue #22664 (comment), we could treat
secure: true
endpoints in the same way as endpoints withurlRewriteSupported: true
(i.e. serve such endpoints through the main gateway):secure
is true on an endpoint, treat that endpoint as though it hadurlRewriteSupported: true
secure: true
buturlRewriteSupported: false
, either warn the user that thesecure
field is being ignored in this case (as we cannot secure such endpoints) or fail the workspace.We would need to be careful around making this change as it would potentially break existing endpoints in workspaces -- I don't know a good way to avoid that.
Describe alternatives you've considered
No response
Additional context
See issue: #22664
The text was updated successfully, but these errors were encountered: