Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'OcpUserLoginPage' to login in OCP cluster without OAuth config #22823

Closed
artaleks9 opened this issue Feb 15, 2024 · 0 comments
Closed
Assignees
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@artaleks9
Copy link
Contributor

Is your task related to a problem? Please describe

The E2E test DevConsoleIntegration uses the OcpUserLoginPage method to login to OCP cluster, there is a bit hard code - waiting the LoginProviderTitle:

if (OAUTH_CONSTANTS.TS_OCP_LOGIN_PAGE_PROVIDER_TITLE !== '') {
	await this.ocpLogin.waitAndClickOnLoginProviderTitle();
}

https://github.com/eclipse/che/blob/main/tests/e2e/pageobjects/login/openshift/OcpUserLoginPage.ts#L25

In the case when is used OCP cluster without OAuth config the test DevConsoleIntegration is failure.

Describe the solution you'd like

This can be resolved by update the OcpUserLoginPage method to replace the condition expression:
if (await this.ocpLogin.isIdentityProviderLinkVisible())

E.g. -> https://github.com/eclipse/che/blob/main/tests/e2e/pageobjects/login/openshift/RegularUserOcpCheLoginPage.ts#L44

This allows to run the test on OCP cluster as with OAuth config , as without the one.

Describe alternatives you've considered

No response

Additional context

No response

@artaleks9 artaleks9 added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/qe team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Feb 15, 2024
@artaleks9 artaleks9 self-assigned this Feb 15, 2024
@artaleks9 artaleks9 added the status/in-progress This issue has been taken by an engineer and is under active development. label Feb 15, 2024
@artaleks9 artaleks9 added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 15, 2024
@artaleks9 artaleks9 changed the title Update 'OcpUserLoginPage' method to login in OCP cluster without OAuth config Update 'OcpUserLoginPage' to login in OCP cluster without OAuth config Feb 15, 2024
@artaleks9 artaleks9 removed status/in-progress This issue has been taken by an engineer and is under active development. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Development

No branches or pull requests

1 participant