Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Che CR provide a way to set the runtime class for all CDE pods #23032

Closed
dkwon17 opened this issue Jul 9, 2024 · 2 comments · Fixed by eclipse-che/che-operator#1899
Closed

In the Che CR provide a way to set the runtime class for all CDE pods #23032

dkwon17 opened this issue Jul 9, 2024 · 2 comments · Fixed by eclipse-che/che-operator#1899
Assignees
@dkwon17
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Jul 9, 2024 •
edited
Loading

Is your enhancement related to a problem? Please describe

Currently to set the runtime class for a CDE pod, the pod-overrides are used to set the CDE pod's spec.runtimeclassname field for each CDE.

Describe the solution you'd like

It would be convenient if there was a Che CR field spec.devnvironments.runtimeclassname that sets the runtime class for each new CDE pod

Describe alternatives you've considered

Otherwise, if an admin wants to set the runtimeclass for all CDEs, the admin needs to add it using pod-overrides for each devworkspace object

Additional context

Related devworkspace-operator issue: devfile/devworkspace-operator#1286
No response
@dkwon17 dkwon17 added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 9, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 9, 2024
@dkwon17 dkwon17 mentioned this issue Jul 9, 2024
Closed
@dkwon17 dkwon17 added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/devworkspace-operator and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 9, 2024
@dmytro-ndp dmytro-ndp added the severity/P2 Has a minor but important impact to the usage or development of the system. label Jul 10, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Jul 11, 2024

@l0rd FYI

@l0rd
Copy link
Contributor

l0rd commented Jul 12, 2024

Great 👍

@dkwon17 dkwon17 self-assigned this Jul 17, 2024
@dkwon17 dkwon17 mentioned this issue Sep 16, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkwon17 dkwon17

Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator area/devworkspace-operator kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
Eclipse Che Team B Backlog
Status: ✅ Done
Red Hat OpenShift Dev Spaces and WebTerminal Priorities
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add spec.devEnvironments.runtimeClassName field to CR dkwon17/che-operator
5 participants
@l0rd @dmytro-ndp @ibuziuk @che-bot @dkwon17