-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #1221
Improvements #1221
Conversation
1. Fixed errors with command substitution of the che properties file. 2. Added in logic to reboot che server if VM was poorly suspended. 3. Allow users to choose latest vs. nightly vs. tagged version with flag in Vagrantfile 4. Allow users to change the IP address used in the Vagrantfile @eivantsov - please check. Authored in response to GitHub issue CHE-1207
@TylerJewell worked for me |
|
||
let counter=counter+1 | ||
sleep 5 | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if server will not be able to boot at all? there should be exit after some amount of tries.
Also on some environments server may start longer than 30 secs and in that case you will be in a endless loop with wait starting & reboot server. I think we have to let server few mins to start and than check is it running, try restart and if restart didn;t help we have to exit that loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep +1 - added.
1. Allow IP to be configured by user. 2. Exit after 3 minutes if the server is not reachable
Build finished. |
Build finished. |
echo vagrant | sudo -S -E -u vagrant /home/vagrant/eclipse-che-*/bin/che.sh --remote:${IP} --skip:client -g start &>/dev/null | ||
fi | ||
# If we are not awake after 180 seconds, restart server | ||
if [ $counter == "35" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong comment, we not restart after 180 sec, we exit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - thanks
LGTM |
Build # 550 - $BUILD_STATUS: Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/550/ to view the results. Failed tests: ${FAILED_TESTS} |
@eivantsov - please check. Authored in response to GitHub issue CHE-1207