Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #1221

Merged
merged 5 commits into from
May 11, 2016
Merged

Improvements #1221

merged 5 commits into from
May 11, 2016

Conversation

TylerJewell
Copy link

  1. Fixed errors with command substitution of the che properties file.
  2. Added in logic to reboot che server if VM was poorly suspended.
  3. Allow users to choose latest vs. nightly vs. tagged version with flag in Vagrantfile
  4. Allow users to change the IP address used in the Vagrantfile

@eivantsov - please check. Authored in response to GitHub issue CHE-1207

1. Fixed errors with command substitution of the che properties file.
2. Added in logic to reboot che server if VM was poorly suspended.
3. Allow users to choose latest vs. nightly vs. tagged version with flag in Vagrantfile
4. Allow users to change the IP address used in the Vagrantfile

@eivantsov - please check.  Authored in response to GitHub issue CHE-1207
@ghost
Copy link

ghost commented May 11, 2016

@TylerJewell worked for me


let counter=counter+1
sleep 5
done
Copy link
Contributor

@riuvshin riuvshin May 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if server will not be able to boot at all? there should be exit after some amount of tries.
Also on some environments server may start longer than 30 secs and in that case you will be in a endless loop with wait starting & reboot server. I think we have to let server few mins to start and than check is it running, try restart and if restart didn;t help we have to exit that loop.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep +1 - added.

1. Allow IP to be configured by user.
2. Exit after 3 minutes if the server is not reachable
@codenvy-ci
Copy link

Build finished.

@codenvy-ci
Copy link

Build finished.

echo vagrant | sudo -S -E -u vagrant /home/vagrant/eclipse-che-*/bin/che.sh --remote:${IP} --skip:client -g start &>/dev/null
fi
# If we are not awake after 180 seconds, restart server
if [ $counter == "35" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment, we not restart after 180 sec, we exit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - thanks

@riuvshin
Copy link
Contributor

LGTM

@TylerJewell TylerJewell merged commit 944aaf1 into master May 11, 2016
@TylerJewell TylerJewell deleted the CHE-1207 branch May 11, 2016 17:20
@codenvy-ci
Copy link

@codenvy-ci
Copy link

@codenvy-ci
Copy link

Build # 550 - $BUILD_STATUS:

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/550/ to view the results.

Failed tests: ${FAILED_TESTS}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants