Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Get Started Tab with e2e tests in dashboard-next #18428

Merged
merged 57 commits into from
Feb 4, 2021
Merged

Cover Get Started Tab with e2e tests in dashboard-next #18428

merged 57 commits into from
Feb 4, 2021

Conversation

Ohrimenko1988
Copy link
Contributor

@Ohrimenko1988
Update pageobject for the 'dashboard-next' changes
2f79634 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Merge branch 'master' of github.com:eclipse/che into iokhrime-dashboa…
9f35f3a 
…rd-next
@Ohrimenko1988
Rework existing tests for the 'dashboard-next' changes
ae82071 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Rework deleting workspace
2209848 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Remove redundant debug steps
8043536 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Remove redundant debug steps
fde426a 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Add possibility to run single devfile
a576d32 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Nov 23, 2020
Closed
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 23, 2020
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Nov 23, 2020
Closed
11 tasks
@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Update the 'Happy Path' test
31a1930 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 24, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Update the IDE iframe locator
1ad903a 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 24, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Update 'run' command
48fecd6 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 24, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Nov 25, 2020
Closed
@che-bot
Copy link
Contributor

che-bot commented Nov 26, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Update Jenkinsfile
e943ef2 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Remove rwdundant lines
314ce18 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
sleshchenko
sleshchenko approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not expert in this codebase, so I even did not review changes but approving it since it works pretty stably for dashboard PR checks for a quite long time.

dmytro-ndp
dmytro-ndp reviewed Feb 2, 2021
View reviewed changes
tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts Outdated
const terminal: Terminal = e2eContainer.get(CLASSES.Terminal);
const debugView: DebugView = e2eContainer.get(CLASSES.DebugView);
const warningDialog: DialogWindow = e2eContainer.get(CLASSES.DialogWindow);
const projectName: string = 'petclinic';
const workspaceRootFolderName: string = 'src';
const namespace: string = TestConstants.TS_SELENIUM_USERNAME;
// const namespace: string = TestConstants.TS_SELENIUM_USERNAME;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need commented lines?

dmytro-ndp
dmytro-ndp reviewed Feb 2, 2021
View reviewed changes
tests/e2e/tests/e2e_happy_path/HappyPath.spec.ts Outdated
const workspaceName: string = TestConstants.TS_SELENIUM_HAPPY_PATH_WORKSPACE_NAME;
const workspaceUrl: string = `${TestConstants.TS_SELENIUM_BASE_URL}/dashboard/#/ide/${namespace}/${workspaceName}`;
// const workspaceUrl: string = `${TestConstants.TS_SELENIUM_BASE_URL}/dashboard/#/ide/${namespace}/${workspaceName}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need commented lines?

tests/.infra/crw-ci/dashboard-next/pr-check/Jenkinsfile Outdated
mutableCheImageTag = ""
pathToChectl = ""

CHE_REPO_BRANCH = "iokhrime-dashboard-next"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's pr check, there should be PR specific branch in dashboard repo

tests/.infra/crw-ci/dashboard-next/pr-check/Jenkinsfile Outdated
pathToChectl = ""

CHE_REPO_BRANCH = "iokhrime-dashboard-next"
DASHBOARD_NEXT_REPO_URL="https://github.com/eclipse/che-dashboard.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's pr check, there should be PR specific dashboard repo (fork)

@Ohrimenko1988
Do changes according to review
54f1d4a 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Do changes according to review
e1491d9 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@Ohrimenko1988
Do changes according to review
6021f17 
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp
dmytro-ndp approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dmytro-ndp
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@dmytro-ndp
Copy link
Contributor

[crw-ci-test --rebuild]

@che-bot
Copy link
Contributor

che-bot commented Feb 3, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Copy link
Contributor Author

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988
Copy link
Contributor Author

[crw-ci-test]

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Ohrimenko1988 Ohrimenko1988 merged commit 01315a0 into master Feb 4, 2021
@Ohrimenko1988 Ohrimenko1988 deleted the iokhrime-dashboard-next branch February 4, 2021 10:41
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 4, 2021
@Ohrimenko1988 Ohrimenko1988 mentioned this pull request Feb 4, 2021
Closed
22 tasks
@che-bot che-bot added this to the 7.26 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.26
Development

Successfully merging this pull request may close these issues.
4 participants
@Ohrimenko1988 @che-bot @dmytro-ndp @sleshchenko