Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-2002 fix wrong workspace ID for SSH target #2003

Merged
merged 3 commits into from
Aug 9, 2016
Merged

CHE-2002 fix wrong workspace ID for SSH target #2003

merged 3 commits into from
Aug 9, 2016

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 31, 2016

What does this PR do?

1.Fix wrong workspace ID for SSH target.
2.Increase ssh connection timeout.
3.Improve target development widget - add a new field with dockerfile source.

What issues does this PR fix or reference?
#2002

selection_020

Please review @vparfonov @ashumilova @vitaliy-guliy

@olexii4
Copy link
Contributor Author

olexii4 commented Jul 31, 2016

selection_021

@codenvy-ci
Copy link

Build # 1351 - FAILED

Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1351/ to view the results.

@vparfonov
Copy link
Contributor

ok

@ashumilova
Copy link
Contributor

as far as Source content field is displayed based on the type of machine, not on whether source is url or content based, so, please, add proper tracking of these cases if we introduce source content input.
+1 for other changes

@vitaliy-guliy
Copy link
Contributor

LGTM

@codenvy-ci
Copy link

Build finished.
Build success. $BUILD_URL

@codenvy-ci
Copy link

Oleksii Orel added 3 commits August 9, 2016 19:46
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Signed-off-by: Oleksii Orel <oorel@codenvy.com>
@olexii4 olexii4 merged commit 08344fe into master Aug 9, 2016
@olexii4 olexii4 added this to the 4.7.0 milestone Aug 9, 2016
@olexii4 olexii4 deleted the CHE-2002 branch August 9, 2016 16:57
@codenvy-ci
Copy link

Build # 44 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/44/ to view the results.

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
CHE-2002 fix wrong workspace ID for SSH target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants