Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-2528: Start workspace after renaming of environment #3521

Merged
merged 4 commits into from
Jan 10, 2017
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 26, 2016

What does this PR do?

When snapshot(s) is not found on workspace start, notifies a user with message in machine start log and starts machine from its recipe.

What issues does this PR fix or reference?

#2528

Previous behavior

Failed to start workspace after renaming environment with snapshot(s).

New behavior

Workspace starts without snapshot(s) in case when snapshot(s) is not found.

Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
Mykola Morhun added 2 commits December 26, 2016 17:53
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
# Conflicts:
#	wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/environment/server/CheEnvironmentEngine.java
@codenvy-ci
Copy link

Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
@codenvy-ci
Copy link

Copy link

@garagatyi garagatyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evoevodin Please take a look

@mmorhun mmorhun merged commit 35b2a24 into master Jan 10, 2017
@mmorhun mmorhun deleted the CHE-2528-2 branch January 10, 2017 09:57
@slemeur slemeur added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 18, 2017
@slemeur slemeur added this to the 5.1.0 milestone Jan 18, 2017
@JamesDrummond JamesDrummond mentioned this pull request Jan 31, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
…3521)

CHE-2528: Start workspace after renaming of environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants