CHE-1979: Fix closing terminal widget on typing "exit" or when user kills terminal process #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolusha
reviewed
Dec 28, 2016
| socket.setOnCloseHandler(new ConnectionClosedHandler() { | ||
| @Override | ||
| public void onClose(WebSocketClosedEvent event) { | ||
| if (CLOSE_NORMAL == event.getCode()) { |
There was a problem hiding this comment.
Why we close terminal if and only if CLOSE_NORMAL == event.getCode() ?
There was a problem hiding this comment.
Because, in case abnormal closing launches onErrorHandler and we try reconnect to terminal...
tolusha
approved these changes
Dec 28, 2016
azatsarynnyy
approved these changes
Dec 28, 2016
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1476/ |
voievodin
approved these changes
Jan 11, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1573/ |
…ls terminal process Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
CHE-1979
branch
from
095b17e
to
ab619a3
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1585/ |
slemeur
added
the
kind/bug
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ls terminal process (eclipse-che#3554) Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix closing terminal widget on typing "exit" or when user kills terminal process by "SIGHUP", "SIGTERM", "SIGKILL" and so on.
What issues does this PR fix or reference?
#1979
Please review @evoevodin @tolusha @azatsarynnyy