CODENVY-1150: Refactor docker hosts evaluation #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make addition of che host into hosts file optional. Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
garagatyi
requested review from
skabashnyuk,
mshaposhnik,
voievodin,
sleshchenko and
akorneta
skabashnyuk
approved these changes
Jan 11, 2017
sleshchenko
approved these changes
Jan 11, 2017
mshaposhnik
approved these changes
Jan 11, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1579/ |
slemeur
added
the
kind/enhancement
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make addition of che host into hosts file optional.
What issues does this PR fix or reference?
Related to codenvy/codenvy#1150
Previous behavior
All Che implementations used to add hosts entries even when it is not needed.
New behavior
Che implementation has more granular control on hosts entries.
Tests written?
No