Fixes mapping of custom port with CHE_PORT #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
added
kind/bug
This was referenced Jan 14, 2017
benoitf
approved these changes
Jan 14, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1636/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where changing ports would prevent Che from starting due to an unexpected use of
CHE_PORTbeing passed intoeclipse/che-server. Previously, we always assumed that the internaleclipse/che-servercontainer would boot on port8080and then we just provide a port mapping from the custom port to the internal port. The new configuration approach actually passesCHE_PORTintoeclipse/che-server, which causes the server to start internally on a different port.This quick fix maps the external port to the internal port.
What issues does this PR fix or reference?
#3179