Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3565: apply config changes automatically #3750

Merged
merged 1 commit into from
Jan 19, 2017
Merged

CHE-3565: apply config changes automatically #3750

merged 1 commit into from
Jan 19, 2017

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR removes "Apply" button from Config import tab and makes changes to be applied automatically.

What issues does this PR fix or reference?

#3565

New behavior

anim

Tests written?

Yes

Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com

- use 'stack-validation' service to show config structure errors
- add 'che-error-messages' service and directive
  to get and manage validation messages from other directives
- add test

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
@codenvy-ci
Copy link

Build # 1648 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1648/ to view the results.

@ashumilova ashumilova added this to the 5.2.0 milestone Jan 19, 2017
@ashumilova
Copy link
Contributor

PR can be merged, as far as workspace docs will be added by https://github.com/codenvy/che-docs/issues/73

@akurinnoy akurinnoy merged commit 3731cb9 into master Jan 19, 2017
@akurinnoy akurinnoy deleted the CHE-3565 branch January 23, 2017 09:05
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
- use 'stack-validation' service to show config structure errors
- add 'che-error-messages' service and directive
  to get and manage validation messages from other directives
- add test

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
- use 'stack-validation' service to show config structure errors
- add 'che-error-messages' service and directive
  to get and manage validation messages from other directives
- add test

Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants