Fix #3686 : Property around external docker has been changed in a refactoring #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actoring but it has not been updated everywhere Change-Id: I6da2c6f33cc063dda08b953eb2fab16abe4a0c86 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
TylerJewell
approved these changes
Jan 16, 2017
|
Thanks for finding this. I had assumed that this was internal to the Che server code because alex had indicated internal restructuring. what must have happened is that they have stopped using the old property name and only now use the new property name. Or, the mapping of the old property to new property somehow is failing. Thanks for fixing this, Florent. |
|
Build # 1652 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1652/ to view the results. |
riuvshin
approved these changes
Jan 17, 2017
benoitf
added
the
kind/bug
|
Sorry I missed this in #3282. I think the issue was that previously, |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…ed in a refactoring but it has not been updated everywhere (eclipse-che#3753) Change-Id: I6da2c6f33cc063dda08b953eb2fab16abe4a0c86 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but it has not been updated everywhere
I did a look for 10 minutes as blocker #3686 is not solved for a long time?
it seems to be broken by #3282 merge
What does this PR do?
Fix boot of Che workspaces on mac (and maybe windows) with CLI
What issues does this PR fix or reference?
#3686
Change-Id: I6da2c6f33cc063dda08b953eb2fab16abe4a0c86
Signed-off-by: Florent BENOIT fbenoit@codenvy.com