Removed one superfluous constructor.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
eclipse-ditto · Jul 12, 2022 · 5654a8f · 5654a8f
1 parent fef2fbd
commit 5654a8f
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/...in/java/org/eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/MqttClientActor.java b/...in/java/org/eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/MqttClientActor.java
@@ -81,25 +81,13 @@ public final class MqttClientActor extends BaseClientActor {
     @Nullable private ActorRef publishingActorRef;
     private final List<ActorRef> mqttConsumerActorRefs;
 
-    @SuppressWarnings("unused") // called by reflection
+    @SuppressWarnings("java:S1144") // called by reflection
     private MqttClientActor(final Connection connection,
             final ActorRef proxyActor,
             final ActorRef connectionActor,
             final DittoHeaders dittoHeaders,
             final Config connectivityConfigOverwrites) {
 
-        this(connection, proxyActor, connectionActor, dittoHeaders, connectivityConfigOverwrites,
-                GenericMqttClientFactory.newInstance());
-    }
-
-    @SuppressWarnings("java:S1144")
-    private MqttClientActor(final Connection connection,
-            final ActorRef proxyActor,
-            final ActorRef connectionActor,
-            final DittoHeaders dittoHeaders,
-            final Config connectivityConfigOverwrites,
-            final GenericMqttClientFactory genericMqttClientFactory) {
-
         super(connection, proxyActor, connectionActor, dittoHeaders, connectivityConfigOverwrites);
 
         final var connectivityConfig = connectivityConfig();
@@ -108,7 +96,7 @@ private MqttClientActor(final Connection connection,
 
         mqttSpecificConfig = MqttSpecificConfig.fromConnection(connection, mqttConfig);
 
-        this.genericMqttClientFactory = genericMqttClientFactory;
+        genericMqttClientFactory = GenericMqttClientFactory.newInstance();
         genericMqttClient = null;
         automaticReconnect = new AtomicBoolean(true);
         publishingActorRef = null;