Resolved TODO comments as they are resolved now.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
eclipse-ditto · Jul 4, 2022 · 8bcc78c · 8bcc78c
1 parent b36e8a8
commit 8bcc78c
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/...in/java/org/eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/MqttClientActor.java b/...in/java/org/eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/MqttClientActor.java
@@ -442,8 +442,6 @@ private ActorRef startMqttConsumerActorOrThrow(final SubscribeResult subscribeRe
                             subscribeResult.getMqttPublishSourceOrThrow())
             );
         } else {
-
-            // TODO jff really no entry in connection log?
             throw subscribeResult.getErrorOrThrow();
         }
     }

diff --git a/...eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/consuming/MqttConsumerActor.java b/...eclipse/ditto/connectivity/service/messaging/mqtt/hivemq/consuming/MqttConsumerActor.java
@@ -181,7 +181,6 @@ private KillSwitch dropAndLogMqttPublishes() {
     private KillSwitch processMqttPublishes() {
         final var mqttPublishTransformer = MqttPublishToExternalMessageTransformer.newInstance(sourceAddress, source);
 
-        // TODO jff backpressure should work this way, right?
         return mqttPublishSource.viaMat(KillSwitches.single(), Keep.right())
                 .map(mqttPublishTransformer::transform)
                 .divertTo(getTransformationFailureSink(), TransformationResult::isFailure)