Switch to ByteSerializer and ByteDeserializer for Kafka Consumer and Publisher #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Publisher * This allows us to ensure that bytes will not be modified based on charset Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
…oad type of our ExternalMessage Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
thjaeckle
reviewed
Nov 24, 2021
base/model/src/main/java/org/eclipse/ditto/base/model/common/ByteBufferUtils.java
Show resolved
Hide resolved
thjaeckle
reviewed
Nov 24, 2021
base/model/src/main/java/org/eclipse/ditto/base/model/common/ByteBufferUtils.java
Outdated
Show resolved
Hide resolved
dguggemos
reviewed
Nov 24, 2021
...java/org/eclipse/ditto/connectivity/service/messaging/kafka/KafkaMessageTransformerTest.java
Outdated
Show resolved
Hide resolved
* Remove unused imports * Remove temporary unittest * Add missing javadoc Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
thjaeckle
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yannic Klem yannic.klem@bosch.io