Optimize any/all/noneSatisfy on UnifiedMapWithHashingStrategy - closes #1342

[Desislav-Petrov]

PR - would appreciate a review @donraab

Looks like existing tests already cover this refactoring

[donraab]

Thank you for the contribution @Desislav-Petrov. I think it would be better to duplicate the functionality in the shortCircuit/shortCircuitWith methods than to externalize the functionality to MapIterate. MapIterate is intended to iterate over Maps, and this iterates over an array, requiring MapIterate to understand how the internals of UnifiedMap and UnifiedMapWithHashingStrategy are implemented.

[Desislav-Petrov]

Thanks for the review @donraab - fair points, made the changes & rebased

[motlin]

To review this, I checked it out locally and diff'd UnifiedMap with UnifiedMapWithHashingStrategy. I found that the new methods were added in a different location, so diff'ing didn't work. I made the fix so that I could continue the review, but you'll have to apply it as well.

d4018e6

Once I did this I could see that the new implementation and the old are identical, and are good to go. Please move the methods to the same positions and then we ought to merge this.

[Desislav-Petrov]

Thx for the feedback @motlin - changes made

[motlin]

@Desislav-Petrov could you also rebase onto upstream/master and then I'll merge?

[Desislav-Petrov]

Done @motlin