-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize any/all/NoneSatisfy on UnifiedMapWithHashingStrategy #1342
Comments
Happy to take a look at this |
hi @donraab started looking at the issue - looks like we need implement the three methods on the UnifiedMapWithHashingStrategy with a similar implementation to the one in UnifiedMap. To avoid the duplication, we should probably extract the helper methods into a common util and reuse? |
The ultimate way to reduce code duplication would be to say our mutable maps are all |
Thanks @motlin - I was looking at it and it seemed nasty to just copy/paste the code so I decided to take it out in the util class and reuse. |
The methods
anySatisfy
,allSatisfy
andnoneSatisfy
should be optimized onUnifiedMapWithHashingStrategy
similar to how they are optimized onUnifiedMap
.The text was updated successfully, but these errors were encountered: