Critical completion issue for completions on a object inside block

[gayanper]

package com.example.demo;

import java.util.function.Supplier;

public class MyFilter {

    public void filter() {
        if (true) {
            Response response = new Response();
            response.beforeCommit(() -> {
                return null;
            });
        }
    }

    private static class Response {

        public void beforeCommit(Supplier<Object> supplier) {
        }

    }
}

if you try to invoke completions at response. you will not get any completions. The completions will start work if you take that statement out of if block or remove the lambda block parameter.

[gayanper]

This seems to work in jdt.core master.

[snjeza]

This is an upstream VS Code issue.
The following code works fine:

response.|beforeCommit(() -> {return null;});

response.|beforeCommit(null);

response.| beforeCommit(() -> { // there is a blank after the cursor
                return null;
            });

response.| beforeCommit( // there is a blank after the cursor
                null);

The following code doesn't work

response.|beforeCommit(() -> {
                return null;
            });

response.|beforeCommit(
                null);

The issue can't be reproduced in jdt.core >= v20221202-2024 (Java LS Pre-Release use it)

[gayanper]

@snjeza from your above comment its not a upstream issue if we upgrade to latest milestone or i-build release in the pre-release LS version right ?

[snjeza]

@gayanper it isn't Eclipse jdt issue. It is a VS Code issue. I will fix it.