Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send COMPLETION_EXECUTION_TIME once per completion request #2621

Closed
fbricon opened this issue Apr 26, 2023 · 2 comments · Fixed by #2635
Closed

Only send COMPLETION_EXECUTION_TIME once per completion request #2621

fbricon opened this issue Apr 26, 2023 · 2 comments · Fixed by #2635
Assignees
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 26, 2023

Currently COMPLETION_EXECUTION_TIME is duplicated in the data section of each completion item returned by the completion request. It could be sent only once at the root of the response, to reduce the payload size

@jdneo jdneo self-assigned this Apr 26, 2023
@rgrunber
Copy link
Contributor

Looking at CompletionList, it does appear to have itemDefaults.data : LSPAny, so we should be able to add it there, since we do have itemDefaults support.

@jdneo
Copy link
Contributor

jdneo commented Apr 27, 2023

Looking at CompletionList, it does appear to have itemDefaults.data : LSPAny, so we should be able to add it there, since we do have itemDefaults support.

I tried that but not succeed. If the completion item has data set, then it just simply replaces the data in itemDefaults (not merging). in each completion item, there are unique pid & rid, so we cannot put common data into itemDefaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants