Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise "friendly" Python startup wrapper a bit more prominently #2020

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

joaotavora
Copy link

Also fix a typo.

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@testforstephen
Copy link
Contributor

ok to test

@testforstephen
Copy link
Contributor

@joaotavora Thanks for contribution, Could you pls sign eclipse eca for this PR?

https://accounts.eclipse.org/user/login?destination=legal/eca/validation/96929

@rgrunber
Copy link
Contributor

rgrunber commented Apr 6, 2022

@joaotavora any update here. We can probably merge as soon as the ECA is signed.

@joaotavora
Copy link
Author

This is a legally insignificant change, i don't think I need to assign copyright for it. In Emacs we have copyright assignment, too, but only for legally significant changes. I don't mind if you rephrase my change slightly and then commit it under different authorship.

@rgrunber rgrunber force-pushed the patch-1 branch 2 times, most recently from 13473eb to af38636 Compare April 6, 2022 18:32
- Also fix a typo.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber
Copy link
Contributor

rgrunber commented Apr 6, 2022

This change is :

  • Making a proper heading for the wrapper script
  • Fixing some typos
  • Mentioning the minimum required Python version

I've also fixed some extra spaces I found.
Thanks for taking the time to point these out.

@rgrunber rgrunber merged commit 911e7c1 into eclipse-jdtls:master Apr 6, 2022
@rgrunber rgrunber added this to the Early April 2022 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants