Avoid blocking the pipeline while handling refreshLocal during document lifecycle events #2659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #2518 (comment).
As shown in the callstack below, the default
refreshLocal
implementation uses two locks: a scheduling rule for jobmanager concurrency and a workspace lock for workspace tree modification. The workspace lock is essential to prevent the workspace tree from being corrupted during refresh. We can try setting the scheduling rule to null forrefreshLocal
in documentLifecycleHandler, since it only refreshes the current Java file and has a limited scope. I tested the new refresh approach with use cases such as creating, renaming and saving a Java file, it works fine.