Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postfix completion for sysouf, sysoutv, format, par, and not #2691

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

hopehadfield
Copy link
Contributor

Per #2288

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@rgrunber rgrunber self-requested a review June 7, 2023 14:27
@fbricon
Copy link
Contributor

fbricon commented Jun 7, 2023

add to whitelist

@hopehadfield hopehadfield marked this pull request as ready for review June 8, 2023 13:59
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good! Just one small thing to address.

@hopehadfield hopehadfield force-pushed the 2288-souf-completion branch 2 times, most recently from eeeb495 to ef55154 Compare June 9, 2023 20:48
@rgrunber rgrunber merged commit c4a4869 into eclipse-jdtls:master Jun 12, 2023
@jdneo
Copy link
Contributor

jdneo commented Jun 12, 2023

Thank you @hopehadfield.

I just updated the list in #2288 (comment) according to your contribution.

@hopehadfield hopehadfield deleted the 2288-souf-completion branch June 12, 2023 13:36
@rgrunber rgrunber added this to the End June 2023 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants