Fix an incorrect calculation of how to shift a mrtree layout. #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The padding is now correctly taken from the parent not the first child and only the left and top paddings are used to compute the offset.
Eddykasp
added
bug
size calculation is correct.
soerendomroes
requested changes
Aug 28, 2024
test/org.eclipse.elk.alg.mrtree.test/.settings/org.eclipse.jdt.core.prefs
Outdated
Show resolved
Hide resolved
...org.eclipse.elk.alg.mrtree.test/src/org/eclipse/elk/alg/mrtree/test/MrTreeGraphSizeTest.java
Outdated
Show resolved
Hide resolved
...org.eclipse.elk.alg.mrtree.test/src/org/eclipse/elk/alg/mrtree/test/MrTreeGraphSizeTest.java
Outdated
Show resolved
Hide resolved
...org.eclipse.elk.alg.mrtree.test/src/org/eclipse/elk/alg/mrtree/test/MrTreeGraphSizeTest.java
Outdated
Show resolved
Hide resolved
soerendomroes
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The padding is now correctly taken from the parent not the first child and only the left and top paddings are used to compute the offset.
fixes #1059 and kieler/elkjs#294