Service: changed super class of 'ElkServicePlugin' from 'AbstractUIPlugin' to just 'Plugin' #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailingKieler
force-pushed
the
elkServicePlugin
branch
from
68c3528
to
e249604
Compare
|
Doesn't jface require swt as well? |
uruuru
reviewed
Mar 7, 2020
| import org.eclipse.elk.core.data.ILayoutMetaDataProvider; | ||
| import org.eclipse.elk.core.data.LayoutMetaDataService; | ||
| import org.eclipse.elk.core.service.util.MonitoredOperation; | ||
| import org.eclipse.elk.core.util.Pair; | ||
| import org.eclipse.jface.preference.IPreferenceStore; | ||
| import org.eclipse.ui.IWorkbenchPart; | ||
| import org.eclipse.ui.plugin.AbstractUIPlugin; |
There was a problem hiding this comment.
This should not be required anymore, right?
There was a problem hiding this comment.
Right. Came in while adding this javadoc
I'll refine that.
In its entirety yes. However, here only the preference store interface and impl from JFace are referenced, and the impl is not (and should not be) instantiated in standalone usage. |
…ugin' to just 'Plugin' ... because loading class 'AbstractUIPlugin' seems to require SWT (esp. 'SWTError') on the classpath that may not be available in standalone scenarios; * copied 'IPreferenceStore' provision from 'AbstractUIPlugin' Signed-off-by: Christian Schneider <christian.schneider@typefox.io>
sailingKieler
force-pushed
the
elkServicePlugin
branch
from
e249604
to
80929ff
Compare
|
@uruuru refinement is done. |
|
I'm fine with the changes. @le-cds? |
le-cds
added
core
le-cds
added
the
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because loading class 'AbstractUIPlugin' seems to require SWT (esp. 'SWTError') on the classpath that may not be available in standalone scenarios;
Copied 'IPreferenceStore' provision from 'AbstractUIPlugin'
To my surprise this change is also required in the standalone context,
otherwise failures (java.lang.Error) may happen at locations like this
elk/plugins/org.eclipse.elk.core/src/org/eclipse/elk/core/data/LayoutMetaDataService.java
Lines 63 to 65 in 524db61
This also looks like such a candidate:
elk/plugins/org.eclipse.elk.core.service/src/org/eclipse/elk/core/service/DiagramLayoutEngine.java
Lines 536 to 537 in 883c156