Change from #347 break the FanRouter functionality

[wiresketch]

Change #347 that is seemingly only cosmetic, changes the code in FanRouter handleCollision method from:

		if (index % 2 == 0) {
			bendPoint = new Point(midPoint.x + (index / 2) * (-1 * ySeparation),
					midPoint.y + (index / 2) * xSeparation);
		} else {
			bendPoint = new Point(midPoint.x + (index / 2) * ySeparation,
					midPoint.y + (index / 2) * (-1 * xSeparation));
		}
		if (!bendPoint.equals(midPoint))
			points.insertPoint(bendPoint, 1);

to

		if (index % 2 == 0) {
			bendPoint = new Point(midPoint.x + (int) ((index / 2.0) * -1.0 * ySeparation),
					midPoint.y + (int) ((index / 2.0) * xSeparation));
		} else {
			bendPoint = new Point(midPoint.x + (int) ((index / 2.0) * ySeparation),
					midPoint.y + (int) ((index / 2.0) * -1.0 * xSeparation));
		}
		if (!bendPoint.equals(midPoint)) {
			points.insertPoint(bendPoint, 1);
		}

This breaks the connection drawing in the application that I'm developing. Here's a simple visual example.

Before:

After:

Clearly the new code change is not equivalent to the old one. The effect is that before the condition after the bendPoint calculation was false, but in the changed code it's calculated as true.

[ptziegler]

I assume the problem is due to the fraction now being considered?

Before: ⌊(index / 2)⌋ * (-1 * ySeparation)
After: ⌊(index / 2) * (-1 * ySeparation)⌋

[wiresketch]

Yes, this is what causes the problem.

[azoitl]

As I broke it I'll provide a fix. Will do that right after the repo is ready for 3.20

[ptziegler]

As I broke it I'll provide a fix. Will do that right after the repo is ready for 3.20

I already had a look at it yesterday and I think the easiest way is to simply revert the change and use a PrecisionPoint, to get rid of the deprecation warning. See #385