-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins and GEMOC splash screen show the wrong build time #22
Comments
Actually this is probably the Jenkins server time in the US ... |
For maven I believe we can pass arguments to the JVM like this https://confluence.atlassian.com/jirakb/setting-the-timezone-for-the-java-environment-323392719.html or like this https://stackoverflow.com/questions/23466218/setting-timezone-for-maven-unit-tests-on-java-8 ? For the Jenkins web UI, maybe there is an option in the administration panel of the Jenkins instance? (I don't have access to it) |
We can't access the Jenkins general configuration (only Eclipse administrators do) so we can't change the server/jenkins internal time to europe instead of US (currently is it Eastern Daylight Time (EDT) you can see it at the bottom rigth of jenkins pages). |
the time stamp is created here : https://github.com/eclipse/gemoc-studio/blob/master/gemoc_studio/plugins/org.eclipse.gemoc.gemoc_studio.branding/pom.xml by |
You are right, people might be downloading the studio from anywhere, so we should simply probably stick to UTC if possible, and we should explicitly write "UTC" next to the time stamp. I would vote for doing that for the splash screen, eventually, but that's of course a low priority. So we don't have access to the administration page of the Jenkins? That's too bad, but I guess it's not worth it to contact them for that. Strangely, it's not even possible to choose a custom time zone in the user profile page... |
in addition to the splash and about, we should also check that the .qualifier (ie. -SNAPSHOT) of the plugins and features also get an UTC time, I'm not sure this is the case now... |
see #22 Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
* jenkinsfile now uses declarative syntax as base (fallback to script only in some parts) Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * add Erwan to main recipients Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * upload products and updatesite to download.eclipse.org/gemoc/ in packages/nightly and updates/nightly see #45 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * use UTC time for splash and about box see #22 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * fix path to get the artifact to upload contribute to #45 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * gemoc_studio -> gemoc-studio as base folder ! contribute to #45 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * only zipped products contribute to #45 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * add an index.html page for nightly it indicates the build date and link to CI for nightly build Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * new artwork adapted for eclipse.org Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * change splashscreen to eclipse colors see #46 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * change about box to eclipse colors see #46 Signed-off-by: dvojtise <didier.vojtisek@inria.fr> * only master branch will upload to eclipse web site Signed-off-by: dvojtise <didier.vojtisek@inria.fr>
Splashscreen and About box now show time with UTC about the Jenkins part we can't do much, maybe in the future with upadtes of jenkins that would fix https://issues.jenkins-ci.org/browse/JENKINS-19887 and/or https://issues.jenkins-ci.org/browse/JENKINS-1962... |
For a build performed a few hours ago, both the Jenkins web UI and the generated studio splash screen show the wrong build time, which is a little confusing:
It looks like we make our commits in the middle of the night :)
The text was updated successfully, but these errors were encountered: