Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve example deployer to provide full description #252

Open
dvojtise opened this issue Dec 10, 2021 · 1 comment
Open

Improve example deployer to provide full description #252

dvojtise opened this issue Dec 10, 2021 · 1 comment
Labels
enhancement good first issue Issue that is probably a good issue for first-time contributors

Comments

@dvojtise
Copy link
Contributor

dvojtise commented Dec 10, 2021 •
edited
Loading

Motivation

Current GEMOC example deployer plugins directly extract several projects without a clear indication of the future projects names. (ie. only the Finish button is available)
Additionally, the example description on the root page is very short (2 lines), and the additional description lines aren't shown.
Other example deployers (ocl, xtend, ..., and even ale) have enabled a Next> button allowing to have a view of the extracted projects and a larger view of the description.

Proposed Solution

Enable the Next> button in addition of the Finish button with the proposed intermediate wizard page.

Proposed Implementation

Evaluate if we can easily use org.eclipse.emf.common.ui.examples and org.eclipse.emf.common.ui.wizard.ExampleInstallerWizard as in ALE (https://github.com/gemoc/ale-lang/blob/master/plugins/org.eclipse.emf.ecoretools.ale.examples/plugin.xml), in order to deploy our zipped projects (the zip are produced from running project in the git repo.
@dvojtise dvojtise added enhancement good first issue Issue that is probably a good issue for first-time contributors labels Dec 10, 2021
@dvojtise
Copy link
Contributor Author

I tested quickly and the org.eclipse.emf.common.ui.examples extension point does support zips in projectDescriptor contentURI, so this action should be straightforward :-)

dvojtise added a commit that referenced this issue Feb 4, 2022
@dvojtise
deploy the new K3FSM model examples using emf.common.ui.examples wizard
3cd05a1 
contributes to #252

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
dvojtise added a commit that referenced this issue Feb 7, 2022
@ebousse @dvojtise
Add new k3fsm modeling samples (#257)
bcc4faf 
* Add new k3fsm modeling projects

* Fix wrong paths in launchers for ThreeStates fsm model

* deploy the new K3FSM model examples using emf.common.ui.examples wizard

contributes to #252

* adapt test to new k3fsm examples folder structure

Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>

Co-authored-by: Didier Vojtisek <didier.vojtisek@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Issue that is probably a good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvojtise