Make K3FSM semantics work with null input/outputs #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvojtise
requested changes
Feb 7, 2022
|
|
||
| @Aspect(className=FSM) | ||
| class FSMAspect { | ||
| @Step | ||
| @InitializeModel // <1> |
There was a problem hiding this comment.
the // <1> is a directive for the asciidoc generator, it must stay in the file (or find another way to document it)
cf. https://download.eclipse.org/gemoc/docs/nightly/K3FSM-example.html#_add_semantics_operations
| println("nothing to process, did you forgot to pass parameters to the launch configuration ?") | ||
| } | ||
| } | ||
| @Step | ||
| @Main // <2> |
| } | ||
| } | ||
|
|
||
| @Aspect(className=State) | ||
| class StateAspect { | ||
| @Step // <3> |
| @@ -62,22 +62,20 @@ class StateAspect { | |||
|
|
|||
| @Aspect(className=Transition) | |||
| class TransitionAspect { | |||
|
|
|||
| @Step // <4> | |||
Signed-off-by: Didier Vojtisek <didier.vojtisek@inria.fr>
dvojtise
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the semantics of K3FSM can only execute models where all transitions have both an input and an output string.
This PR solves that, and will make sure the semantics can legally fire a transition that has no input string.
Changes
t.input === nullinputandoutputmay benull