Bugfix npe target percentage #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed NullPointerException in groups validation callback; Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
|
Thanks for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. |
Use current local on string format; Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/DefineGroupsLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/DefineGroupsLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/DefineGroupsLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
May 14, 2019
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/DefineGroupsLayout.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
May 14, 2019
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/rollout/rollout/DefineGroupsLayout.java
Outdated
Show resolved
Hide resolved
|
SonarQube analysis reported 2 issues
Watch the comments in this conversation to review them. |
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Nkyn
force-pushed
the
bugfix_npe_target_percentage
branch
from
4a2ab1c
to
1b3c9d3
Compare
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
* Fixed NullPointerException in groups validation callback Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the value range of target percentage to "1 to 100" in the Configure Rollouts view. The value '0' is no longer valid for the target percentage in the Advanced Group definition.