Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix npe target percentage #819

Merged
merged 5 commits into from
Jun 6, 2019
Merged

Bugfix npe target percentage #819

merged 5 commits into from
Jun 6, 2019

Commits on Mar 8, 2019

  1. Changed min value of target percentage range to 1; 

    Fixed NullPointerException in groups validation callback;

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
    @Nkyn
    Nkyn committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    fe9a996 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Extracted single group validation into an own method 

    Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
    @Nkyn
    Nkyn committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    7b7f225 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Exclude value 0 from target percentage range; 

    Use current local on string format;

Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
    @Nkyn
    Nkyn committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    aed9d03 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Adopting the review comments 

    Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
    @Nkyn
    Nkyn committed May 15, 2019
    Configuration menu
    Copy the full SHA
    b736f41 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Merge branch 'master' into bugfix_npe_target_percentage 

    Signed-off-by: Natalia Kislicyn <natalia.kislicyn@bosch-si.com>
    @Nkyn
    Nkyn committed May 21, 2019
    Configuration menu
    Copy the full SHA
    1b3c9d3 View commit details
    Browse the repository at this point in the history