Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JibServiceUtil pushes separate images for additional tags specified in build configuration #2293

Closed
rohanKanojia opened this issue Jul 19, 2023 Discussed in #2283 · 1 comment · Fixed by #2315
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

Discussed in #2283

Originally posted by maodia July 17, 2023
Hi,i have a question about the pushed image and tags when i use the jib build strategy , so i need a answer or advice.
We use the Harbor for docker image registry, and when we use the default build strategy and the jib build strategy, the image and tags display in the Harbor web view is very different.

Here is the image define fragment in my pom file:

 <image>
      <name>registry.cmread.com/mgsc/demo4k8s-service-consumer</name>
       <build>
           <from>registry.cmread.com/library/openjdk:11-jdk</from>
           <tags>
               <tag>develop</tag>
               <tag>1.0.0</tag>
           </tags>
           <ports>
                 <port>8080</port>
            </ports>
            <assembly>
                 <name>app</name>
            </assembly>
       </build>
 </image>

this is a image of one pushed docker image with three tags display in the harber when we use the default build strategy, and it is what we expect:

0239197caa3502933feb423e3a72bc2

this is a image of three pushed docker image with three tags display in the harber when we use the jib build strategy, and it is not what we expect:
a30a96920e9cec395b3221ae86bd6ee

@rohanKanojia
Copy link
Member Author

We need to make changes in JibServiceUtil as discussed in #2283 (reply in thread)

@manusa manusa added the bug Something isn't working label Jul 19, 2023
@manusa manusa moved this to Planned in Eclipse JKube Jul 26, 2023
@rohanKanojia rohanKanojia self-assigned this Jul 31, 2023
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Jul 31, 2023
@rohanKanojia rohanKanojia moved this from In Progress to Planned in Eclipse JKube Jul 31, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 1, 2023
…onal tags in single request (eclipse-jkube#2293)

We are doing separate push requests for each additional tag provided in
build configuration. Use only single push request and rely on in built
jib's Containerizer.withAdditionalTag method

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 2, 2023
…onal tags in single request (eclipse-jkube#2293)

We are doing separate push requests for each additional tag provided in
build configuration. Use only single push request and rely on in built
jib's Containerizer.withAdditionalTag method

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Aug 2, 2023
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Aug 2, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 7, 2023
…onal tags in single request (eclipse-jkube#2293)

We are doing separate push requests for each additional tag provided in
build configuration. Use only single push request and rely on in built
jib's Containerizer.withAdditionalTag method

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.14.0 milestone Aug 9, 2023
manusa pushed a commit that referenced this issue Aug 9, 2023
…onal tags in single request (#2293)

We are doing separate push requests for each additional tag provided in
build configuration. Use only single push request and rely on in built
jib's Containerizer.withAdditionalTag method

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Aug 9, 2023
ShivangMishra pushed a commit to ShivangMishra/jkube that referenced this issue Aug 13, 2023
…onal tags in single request (eclipse-jkube#2293)

We are doing separate push requests for each additional tag provided in
build configuration. Use only single push request and rely on in built
jib's Containerizer.withAdditionalTag method

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants