Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfileUtilTest.findProfile_whenValidProfileArg_returnsValidProfile The declared Exception exception is never thrown #2778

Closed
1 task done
manusa opened this issue Mar 7, 2024 · 7 comments · Fixed by #2910
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Mar 7, 2024

Description

The method ProfileUtilTest.findProfile_whenValidProfileArg_returnsValidProfile declares an Exception that is never thrown.

The following line
https://github.com/eclipse/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/profile/src/test/java/org/eclipse/jkube/kit/profile/ProfileUtilTest.java#L60

  • should be changed to:
    void findProfile_whenValidProfileArg_returnsValidProfile() throws URISyntaxException {

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Mar 7, 2024
@Jonathanlemon
Copy link
Contributor

Could I be assigned this issue @manusa ?

@rohanKanojia
Copy link
Member

@Jonathanlemon first-timers-only tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.

@ArunErram
Copy link
Contributor

can i work on these issue ?
@manusa @rohanKanojia

@manusa
Copy link
Member Author

manusa commented Apr 9, 2024

can i work on these issue ? @manusa @rohanKanojia

See Rohan's comment:

first-timers-only tagged issues are created for newcomers who are contributing to the project for the first time so that they can complete legal requirements and get familiar with project.

Now that you’ve completed that step, I would advise you to look into issues tagged with good first issue / help wanted labels . Or maybe create some new issue if you find something that should be fixed.

#2589

@agusaar
Copy link
Contributor

agusaar commented Apr 14, 2024

Hi there @manusa , is this issue solved? If not, I would like to work on it.

@agusaar
Copy link
Contributor

agusaar commented Apr 14, 2024

When I try to clone the repository I get the following error:

error: unable to create file jkube-kit/build/api/src/test/resources/assembly/assembly-manager-create-docker-tar-archive/without-dockerfile-and-already-existing-file-in-assembly-gets-overwritten/jkube-generated-layer-final-artifact/maven/test-0.1.0.jar: Filename too long

Is there a chance of modifying the path to the file in order to make it shorter?

@agusaar
Copy link
Contributor

agusaar commented Apr 14, 2024

Solved by settinng core.longpaths to true

@manusa manusa added this to the 1.17.0 milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants