Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceMojo.extractEnricherConfig The declared Exception exception is never thrown #2780

Closed
1 task
manusa opened this issue Mar 7, 2024 · 0 comments · Fixed by #2786
Closed
1 task

ResourceMojo.extractEnricherConfig The declared Exception exception is never thrown #2780

manusa opened this issue Mar 7, 2024 · 0 comments · Fixed by #2786
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Mar 7, 2024

Description

The method ResourceMojo.extractEnricherConfig declares an Exception that is never thrown.

The following line
https://github.com/eclipse/jkube/blob/6818c5bdf610203171cf9536753565b56cb19434/kubernetes-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ResourceMojo.java#L252

  • should be changed to:
    private ProcessorConfig extractEnricherConfig() {

Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇👇👇👇👇👇👇
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Mar 7, 2024
waynemorphic added a commit to waynemorphic/jkube that referenced this issue Mar 7, 2024
… is never thrown eclipse-jkube#2780 Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
@manusa manusa added this to the 1.17.0 milestone Mar 8, 2024
arsenalzp pushed a commit to arsenalzp/jkube that referenced this issue Mar 12, 2024
manusa pushed a commit that referenced this issue Apr 25, 2024
Removed declared exception in ResourceMojo.extractEnricherConfig that is never thrown #2780 Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Added /hello endpoint that prints a message Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Removed declarations of thrown exceptions Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Updated image name Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Updated quickstart readme Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Updated quickstart with requested changes Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Updated project Readme Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
chore(example): Refactored a child class. Signed-off-by: wayne kirimi <kirimiwayne@gmail.com>
---
Merge branch 'master' into improve-example-2788
---
fix/quickstart-example: Fixed requested changes. Signed-off-by:wayne kirimi <kirimiwayne@gmail.com>
---
Update RootHandler.java
---
Readme changes for Hello-World quickstart
---
Readme change
---
review: fix hello-world quickstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant