Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

seat_service: remove bash dependencies from scripts #71

Closed

Conversation

d-s-e
Copy link
Contributor

@d-s-e d-s-e commented May 22, 2023

Removed all bash dependencies and cleaned up the seat service shell scripts.

Signed-off-by: Guenther Meyer <g.meyer@signum-media.de>
@erikbosch
Copy link
Contributor

Looks good to me, but I have not tested that they work as expected. @d-s-e - have you verified that the scripts work as expected after conversion?

@d-s-e
Copy link
Contributor Author

d-s-e commented Jun 14, 2023

I could not test the full scripts, but I tried to not alter the functionality and manually tested most of the replacements I did.
I see no reason, why they shouldn't work.

@int0x27
Copy link
Contributor

int0x27 commented Jun 15, 2023

I'll push a PR that supersedes this one, mainly added can-utills to the docker image and keep it bash compatible.
Current suggestion is not pure sh compatible, so better stay on bash, and if needed you can just replace the shebang line or:
sudo ln -s /bin/sh /bin/bash

@d-s-e
Copy link
Contributor Author

d-s-e commented Jun 15, 2023

@int0x27 How could this help!?
The scripts contain lots of bashisms, simply replacing the shebang can't fix that!
The mentioned symlinks usually exists anyway on systems using bash.

The primary reason for this PR is to remove any dependencies to GPLv3 licensed software (which bash is) on the target.

@int0x27
Copy link
Contributor

int0x27 commented Jun 15, 2023

If this works on sh, probably everything else works:

local data=${frame#*#}

our docker image uses ubuntu runtime image, so bash is included there

@d-s-e
Copy link
Contributor Author

d-s-e commented Jun 15, 2023

If this works on sh, probably everything else works:

That doesn't matter, there are some other lines, that won't work on a system without bash.

our docker image uses ubuntu runtime image, so bash is included there

I don't use your docker image; Ubuntu is way too big for the use case anyway. I build the container image with a bitbake recipe.
The goal is to create a distribution (Eclipse Leda) with preinstalled containers, that can be used without any GPLv3 dependencies.

@int0x27
Copy link
Contributor

int0x27 commented Jun 19, 2023

Can you check /bin/sh changes here:
#79
If they are OK we can close this PR

@d-s-e
Copy link
Contributor Author

d-s-e commented Jun 20, 2023

@int0x27 Looks good to me.

@int0x27 int0x27 closed this Jun 28, 2023
@d-s-e d-s-e deleted the seat_service_remove_bash_dependency branch November 9, 2023 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants