fix(core.configuration): delete Configuration from ConfigurationAdmin #4937
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for 60 days with no activity. |
Signed-off-by: Marcello Martina <martina.marcello.rinaldo@outlook.com>
salvatore-coppola
force-pushed
the
fix-config-service-remove
branch
from
7d34580
to
e996ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the deletion of the
Configurationthat matches thekura.service.pidwhen removing aConfigurableComponentor aSelfConfigurableComponent. This operation is already done on factory configurations.Related Issue: Solves issue #4863. Without this PR the configurations are not removed from the
ConfigurationAdmincausing a mismatch between what is present in theConfigurationAdminand what is currently tracked by theConfigurationService.Description of the solution adopted: N/A.
Screenshots: N/A.
Manual Tests: N/A.
Any side note on the changes made: N/A.