Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api)!: Removed bluetooth old api, implementation, tests and examples #5323

Merged
merged 9 commits into from
Jul 25, 2024

Conversation

pierantoniomerlino
Copy link
Contributor

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

This PR removes the Bluetooth Old APIs, their implementation, the tests and examples. In particular, the following packages are deleted:

  • org.eclipse.kura.bluetooth
  • org.eclipse.kura.bluetooth.listener
  • org.eclipse.kura.linux.bluetooth
  • org.eclipse.kura.example.ble.tisensortag
  • org.eclipse.kura.example.beacon
  • org.eclipse.kura.example.beacon.scanner

Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Build fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:copy (get-kura-bundles) on project distrib: Unable to find artifact. The following artifacts could not be resolved: org.eclipse.kura:org.eclipse.kura.linux.bluetooth:jar:2.0.0-SNAPSHOT (absent): Could not find artifact org.eclipse.kura:org.eclipse.kura.linux.bluetooth:jar:2.0.0-SNAPSHOT in kura_addons (https://raw.github.com/eurotech/kura_addons/mvn-repo/)

@mattdibi
Copy link
Contributor

Also: is this a breaking change?

@pierantoniomerlino
Copy link
Contributor Author

Also: is this a breaking change?

I don't think so... we're removing stuff that has been already deprecated.

Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
@pierantoniomerlino pierantoniomerlino changed the title refactor(api): Removed bluetooth old api, implementation, tests and examples refactor(api)!: Removed bluetooth old api, implementation, tests and examples Jul 24, 2024
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pierantoniomerlino pierantoniomerlino merged commit 83b5252 into develop Jul 25, 2024
7 checks passed
@pierantoniomerlino pierantoniomerlino deleted the remove_bluetooth_old_api branch July 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants