-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lazy collectiing of Workspace Artifacts in completion #483
Make lazy collectiing of Workspace Artifacts in completion #483
Conversation
86d02a5
to
d25a559
Compare
...inx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/LoadedMavenProjectProvider.java
Show resolved
Hide resolved
...inx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/LoadedMavenProjectProvider.java
Show resolved
Hide resolved
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Show resolved
Hide resolved
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Outdated
Show resolved
Hide resolved
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/MavenLemminxExtension.java
Show resolved
Hide resolved
a5e5ccb
to
c132458
Compare
eac2002
to
bfbd68c
Compare
Make Maven Projects to be loaded/cached lazily when collecting the Workspace Artifacts when gathering completions n order to make content assist faster and more responsive Issue: eclipse-lemminx#444
bfbd68c
to
54cda2a
Compare
How is user made aware that the completion results are incomplete because of lazy loading? If there is nothing to warn them, then they may interpret it as a regression. |
At first we have a progress monitor which notifiés the user that local repo is scanning. While this scanning folder, lemminx maven completion is disabled to provide completion items from lemminx like dependency tag elelent based on xsd |
It would be nice if lemminx-maven introduced some dummy item in the completion result to show users that the list is incomplete. An entry such as "More will be provided after local repo is scanned". |
My scan of my big lcal repo takes arround 15 seconds. A thing that we could do when completion is triggered while this scan is to provide artifact which are already scanned |
It existed rhis kind of entry but we removed it because completion item is used to apply it and insert some content not to display some i fo |
Make Maven Projects to be loaded/cached lazily when collecting the Workspace Artifacts when gathering completions n order to make content assist faster and more responsive
Issue: #444