Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lazy collectiing of Workspace Artifacts in completion #483

Conversation

vrubezhny
Copy link
Contributor

Make Maven Projects to be loaded/cached lazily when collecting the Workspace Artifacts when gathering completions n order to make content assist faster and more responsive

Issue: #444

@vrubezhny vrubezhny marked this pull request as draft August 2, 2023 02:43
@vrubezhny vrubezhny force-pushed the fixCollectingWorkspaceArtifactsInCompletion branch 2 times, most recently from 86d02a5 to d25a559 Compare August 4, 2023 15:02
@vrubezhny vrubezhny force-pushed the fixCollectingWorkspaceArtifactsInCompletion branch 3 times, most recently from a5e5ccb to c132458 Compare August 4, 2023 18:41
@vrubezhny vrubezhny marked this pull request as ready for review August 4, 2023 18:50
@vrubezhny vrubezhny force-pushed the fixCollectingWorkspaceArtifactsInCompletion branch 3 times, most recently from eac2002 to bfbd68c Compare August 5, 2023 04:51
Make Maven Projects to be loaded/cached lazily when collecting the Workspace Artifacts
when gathering completions n order to make content assist faster and more responsive

Issue: eclipse-lemminx#444
@vrubezhny vrubezhny force-pushed the fixCollectingWorkspaceArtifactsInCompletion branch from bfbd68c to 54cda2a Compare August 5, 2023 17:19
@vrubezhny vrubezhny merged commit 1b0b710 into eclipse-lemminx:master Aug 5, 2023
2 checks passed
@mickaelistria
Copy link
Contributor

How is user made aware that the completion results are incomplete because of lazy loading? If there is nothing to warn them, then they may interpret it as a regression.
The fact that some assertions had to change in tests do showcase that this can be perceived as a regression if we don't make it very clear and usable to users that more results are to be provided.

@angelozerr
Copy link
Contributor

At first we have a progress monitor which notifiés the user that local repo is scanning.

While this scanning folder, lemminx maven completion is disabled to provide completion items from lemminx like dependency tag elelent based on xsd

@mickaelistria
Copy link
Contributor

It would be nice if lemminx-maven introduced some dummy item in the completion result to show users that the list is incomplete. An entry such as "More will be provided after local repo is scanned".
However, I imagine the operation is relatively quick, so in practice, users almost often get the content of the local repo in the proposals, don't hey?

@angelozerr
Copy link
Contributor

My scan of my big lcal repo takes arround 15 seconds.

A thing that we could do when completion is triggered while this scan is to provide artifact which are already scanned

@angelozerr
Copy link
Contributor

entry such as "More will be provided after local repo is scanned".

It existed rhis kind of entry but we removed it because completion item is used to apply it and insert some content not to display some i fo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants