Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump lsp4j.version from 0.20.1 to 0.21.0 #1529

Closed
wants to merge 1 commit into from
Closed

Bump lsp4j.version from 0.20.1 to 0.21.0 #1529

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 13, 2023 •
edited

Bumps lsp4j.version from 0.20.1 to 0.21.0.
Updates org.eclipse.lsp4j from 0.20.1 to 0.21.0

Release notes

Sourced from org.eclipse.lsp4j's releases.

LSP4J 0.21.0

LSP4J 0.21.0 has now been released and been contributed to simrel, tagged and uploaded to maven central.

Changelog entry

v0.21.0 (May 2023)

  • Implemented DAP version 1.60.0
  • LSP4J's implementation of JSON-RPC 2.0 specification has been fixed regarding de-structure the outermost array wrapper if it's a single array parameter.
    • See #553 for detailed discussion.
  • xbase's @Pure and ToStringBuilder is no longer used by LSP4J
    • See #494 for detailed discussion.

Fixed issues: https://github.com/eclipse-lsp4j/lsp4j/milestone/28?closed=1

Breaking API changes:

  • LSP4J now requires Java 11 to build and run. This can be observed in the japicmp report which says class file format version changed from 52.0 to 55.0. eclipse-lsp4j/lsp4j#547.

japicmp report: https://download.eclipse.org/lsp4j/updates/releases/0.21.0/japicmp-report/

What's Changed (auto-generated)

... (truncated)

Changelog

Sourced from org.eclipse.lsp4j's changelog.

v0.21.0 (May 2023)

  • Implemented DAP version 1.60.0
  • LSP4J's implementation of JSON-RPC 2.0 specification has been fixed regarding de-structure the outermost array wrapper if it's a single array parameter.
    • See #553 for detailed discussion.
  • xbase's @Pure and ToStringBuilder is no longer used by LSP4J
    • See #494 for detailed discussion.

Fixed issues: https://github.com/eclipse-lsp4j/lsp4j/milestone/28?closed=1

Breaking API changes:

  • LSP4J now requires Java 11 to build and run. This can be observed in the japicmp report which says class file format version changed from 52.0 to 55.0. eclipse-lsp4j/lsp4j#547.

japicmp report: https://download.eclipse.org/lsp4j/updates/releases/0.21.0/japicmp-report/

Commits
  • 2540cd3 Prepare repo for 0.21.0 release
  • 87b6d76 Update docs for 0.21.0 release
  • 79df5e2 Void return types need to always be null value
  • 3d55fa0 Fix typo in test name
  • 7040d87 Add missing quotes around body in JSON
  • a526054 Wrap primitive and array parameter into an array as in JSON-RPC 2.0
  • ac1bfd5 Add 0.19.1 to main changelog
  • d9ccef3 Bring DAP protocol implemented up to 1.60.0
  • 3838d20 Add support for startDebugging
  • 1381d0f Update all URLs for new LSP4J GitHub org
  • Additional commits viewable in compare view

Updates org.eclipse.lsp4j.jsonrpc from 0.20.1 to 0.21.0

Release notes

Sourced from org.eclipse.lsp4j.jsonrpc's releases.

LSP4J 0.21.0

LSP4J 0.21.0 has now been released and been contributed to simrel, tagged and uploaded to maven central.

Changelog entry

v0.21.0 (May 2023)

  • Implemented DAP version 1.60.0
  • LSP4J's implementation of JSON-RPC 2.0 specification has been fixed regarding de-structure the outermost array wrapper if it's a single array parameter.
    • See #553 for detailed discussion.
  • xbase's @Pure and ToStringBuilder is no longer used by LSP4J
    • See #494 for detailed discussion.

Fixed issues: https://github.com/eclipse-lsp4j/lsp4j/milestone/28?closed=1

Breaking API changes:

  • LSP4J now requires Java 11 to build and run. This can be observed in the japicmp report which says class file format version changed from 52.0 to 55.0. eclipse-lsp4j/lsp4j#547.

japicmp report: https://download.eclipse.org/lsp4j/updates/releases/0.21.0/japicmp-report/

What's Changed (auto-generated)

... (truncated)

Changelog

Sourced from org.eclipse.lsp4j.jsonrpc's changelog.

v0.21.0 (May 2023)

  • Implemented DAP version 1.60.0
  • LSP4J's implementation of JSON-RPC 2.0 specification has been fixed regarding de-structure the outermost array wrapper if it's a single array parameter.
    • See #553 for detailed discussion.
  • xbase's @Pure and ToStringBuilder is no longer used by LSP4J
    • See #494 for detailed discussion.

Fixed issues: https://github.com/eclipse-lsp4j/lsp4j/milestone/28?closed=1

Breaking API changes:

  • LSP4J now requires Java 11 to build and run. This can be observed in the japicmp report which says class file format version changed from 52.0 to 55.0. eclipse-lsp4j/lsp4j#547.

japicmp report: https://download.eclipse.org/lsp4j/updates/releases/0.21.0/japicmp-report/

Commits
  • 2540cd3 Prepare repo for 0.21.0 release
  • 87b6d76 Update docs for 0.21.0 release
  • 79df5e2 Void return types need to always be null value
  • 3d55fa0 Fix typo in test name
  • 7040d87 Add missing quotes around body in JSON
  • a526054 Wrap primitive and array parameter into an array as in JSON-RPC 2.0
  • ac1bfd5 Add 0.19.1 to main changelog
  • d9ccef3 Bring DAP protocol implemented up to 1.60.0
  • 3838d20 Add support for startDebugging
  • 1381d0f Update all URLs for new LSP4J GitHub org
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 13, 2023
@dependabot dependabot bot force-pushed the dependabot/maven/lsp4j.version-0.21.0 branch from 6e56670 to cb140dd Compare June 13, 2023 23:23
@vrubezhny
Copy link
Contributor

@dependabot rebase

@dependabot
Bump lsp4j.version from 0.20.1 to 0.21.0
2fa69a1 
Bumps `lsp4j.version` from 0.20.1 to 0.21.0.

Updates `org.eclipse.lsp4j` from 0.20.1 to 0.21.0
- [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases)
- [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md)
- [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.21.0)

Updates `org.eclipse.lsp4j.jsonrpc` from 0.20.1 to 0.21.0
- [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases)
- [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md)
- [Commits](eclipse-lsp4j/lsp4j@v0.20.1...v0.21.0)

---
updated-dependencies:
- dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/lsp4j.version-0.21.0 branch from cb140dd to 2fa69a1 Compare June 14, 2023 18:31
@angelozerr
Copy link
Contributor

@vrubezhny please take care of lsp4j version for binary

@vrubezhny
Copy link
Contributor

@vrubezhny please take care of lsp4j version for binary

lsp4j, probably, cannot be updated to 0.21.0 right now:

 class file has wrong version 55.0, should be 52.0

means that this version is built with Java 11 and incompatible with Java 8 used in Lemminx, so, Lemminx is to be moved to this Java version in order to update to this version. I believe move to Java 17 is more preferable.
But I would expect such a change to be done after releasing at least Lemminx 0.26.0.
What do you think?

@angelozerr
Copy link
Contributor

Yes please and we need to check if there are some new classes to declare them in reflect json file used by binary.

What do you think @fbricon @datho7561 @rgrunber to swith to java 17 since now we have binary.

We need to check to the binary build continue to work with java 17

@rgrunber
Copy link
Contributor

rgrunber commented Jun 14, 2023 •
edited

We have binaries for linux-x64, win32-x64, darwin-x64, darwin-arm64 .

VS Code supports win32-x64, win32-ia32, win32-arm64, linux-x64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, darwin-x64, darwin-arm64 and web

So users on win32-ia32, win32-arm64, linux-arm64, linux-armhf, alpine-x64, alpine-arm64, web would not get the binary. I guess the question is are there users on these unsupported (for binary) platforms that would have a JRE 1.8 and not anything higher ? Are we ok with this slight imposition on those platforms.

We could finally fix #1291 if we moved to Java 11 😂

@datho7561
Copy link
Contributor

For Alpine Linux: openjdk11 and openjdk17 both appear to be packaged for the distro in x86_64 and 64bit ARM.

It looks like there is an Eclipse Temurin release for 64bit ARM for Linux (I'm assuming it's for glibc-based Linux since it doesn't say)

That leaves: win32-ia32, win32-arm64, linux-armhf

(I couldn't find a Temurin release for Windows ARM)

@angelozerr angelozerr mentioned this pull request Jun 15, 2023
Open
@w6et
Copy link
Contributor

w6et commented Jul 28, 2023

It looks like there is an Eclipse Temurin release for 64bit ARM for Linux (I'm assuming it's for glibc-based Linux since it doesn't say)

That leaves: win32-ia32, win32-arm64, linux-armhf

(I couldn't find a Temurin release for Windows ARM)

Maybe it's not a problem，See https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-pack ,it required "📦 Language Support for Java™ by Red Hat",Then see https://marketplace.visualstudio.com/items?itemName=redhat.java#setting-the-jdk ,it will embed a JRE for supported platforms such as win32-x64, linux-x64, linux-arm64, darwin-x64, darwin-arm64.and bellow they say "Java 17 is the minimum required version.",Same to see "java.jdt.ls.java.home" description in "https://github.com/redhat-developer/vscode-java/blob/master/package.json" , Java 17 is specified.

@datho7561
Copy link
Contributor

The main issue we are facing is that many of the people who want to edit XML don't want to install Java (see some of the older comments on the marketplace), so they likely won't have vscode-java installed.

Anyone using one of the more obscure architectures that we don't provide a binary for will have to use a Java 17 JDK (or 11? I don't think we necessarily need to go to 17) in order to run vscode-xml. That means any architecture that doesn't have a Java 17 version can't run the extension. To me, it seems like most systems with JDK 8 also have JDK 17, so we won't be cutting off many people from running the extension.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 29, 2023

Superseded by #1578.

@dependabot dependabot bot closed this Aug 29, 2023
@dependabot dependabot bot deleted the dependabot/maven/lsp4j.version-0.21.0 branch August 29, 2023 19:27
@w6et
Copy link
Contributor

w6et commented Dec 2, 2023

The main issue we are facing is that many of the people who want to edit XML don't want to install Java (see some of the older comments on the marketplace), so they likely won't have vscode-java installed.

Anyone using one of the more obscure architectures that we don't provide a binary for will have to use a Java 17 JDK (or 11? I don't think we necessarily need to go to 17) in order to run vscode-xml. That means any architecture that doesn't have a Java 17 version can't run the extension. To me, it seems like most systems with JDK 8 also have JDK 17, so we won't be cutting off many people from running the extension.

Sorry to revisit the issue again.
I've noticed that binary packages have been available since version 0.15.0.
Version 0.15.0 was released on 2021-2-2, almost 3 years ago.
First of all, most people have already upgraded to a version that offers binary packages.
Secondly, even so, consider the following two situations:
Javaer or not Javaer
1)If some people edit xml and don't want to install java(not Javaer),Versions after 0.15.0 are sufficient.
2)If some people edit xml use 'xml.java.home' config(Javaer),The most of people already have JDK 17 installed, or even JDK 21.Even the sparse part, as a Javaer, installing a JDK17 is a no-brainer.
It seems that neither of these two situations has any effect, and it seems that most of them do not require any action.
I've noticed that the dependencies used by Lemminx are basically JDK 11 or higher,
Perhaps consider upgrading the codebase to JDK17 to ensure that the dependent libraries don't fall too far behind.

@rgrunber
Copy link
Contributor

rgrunber commented Dec 2, 2023

The decision to go to a minimum of Java 11 will happen soon. https://github.com/eclipse/lemminx/pull/1607/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R15

@w6et w6et mentioned this pull request Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vrubezhny @angelozerr @rgrunber @datho7561 @w6et