Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error range for duplicate attribute #456

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix error range for duplicate attribute #456

merged 1 commit into from
Jun 20, 2019

Conversation

xorye
Copy link

@xorye xorye commented Jun 20, 2019

image

The error range for both AttributeNSNotUnique and AttributeNotUnique is now on the first occurrence of the duplicate attribute. If needed, it could be on the last occurrence of the attribute, but we would need a method like DOMNode.getAttributeNode(String prefix, String suffix), except it iterates through the list of attributes, backwards.

For the above screenshot, the arguments were:

arguments[0] = "xs:schema"
arguments[1] = "tns"
arguments[2] = "http://www.w3.org/2000/xmlns"

Signed-off-by: David Kwon dakwon@redhat.com

Signed-off-by: David Kwon <dakwon@redhat.com>
@angelozerr angelozerr merged commit 23b2105 into eclipse-lemminx:master Jun 20, 2019
@angelozerr
Copy link
Contributor

It's perfect for me @xorye . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants