Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the cached XSD, DTD grammar file with lazy mode #687

Merged
merged 1 commit into from
May 12, 2020

Conversation

angelozerr
Copy link
Contributor

Read the cached XSD, DTD grammar file with lazy mode

Signed-off-by: azerr azerr@redhat.com

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this May 11, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone May 11, 2020
public InputStream getByteStream() {
// Load the file input stream only if it is used
InputStream input = super.getByteStream();
if (input == null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check if path exists and is a file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is done before (file is null when it doesn't exists), in otherwise don't need to do that here.

@fbricon
Copy link
Contributor

fbricon commented May 12, 2020

@xorye please test this one

@angelozerr angelozerr merged commit 25cf8e4 into eclipse-lemminx:master May 12, 2020
@xorye xorye added the bug Something isn't working label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants