Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dynamic templating in completionSnippets #43

Closed
AnkushSharma2698 opened this issue Nov 5, 2020 · 1 comment
Closed

Implement dynamic templating in completionSnippets #43

AnkushSharma2698 opened this issue Nov 5, 2020 · 1 comment
Assignees
Labels
5 Estimated story points completion Completion item enhancement New feature or request medium priority snippet Snippet item
Milestone

Comments

@AnkushSharma2698
Copy link
Contributor

AnkushSharma2698 commented Nov 5, 2020

Certain key variables should resolve automatically in snippets.
Example:

${package_name}

Should resolve automatically based on the context to

package com.example.system;

I just did some testing, and the proposed method doesnt actually work in eclipse rn. I tried messing around with templates in eclipse and that does fill in snippets with variables as we want but for whatever reason that is not extending to our current completion framework. So for now I would say we should keep snippets like this. In order to accomodate the change in this request I think i would have to restructure completionProposalComputer a bit and I am not sure about what is needed for that yet

@AnkushSharma2698 AnkushSharma2698 added snippet Snippet item completion Completion item labels Nov 5, 2020
@kathrynkodama kathrynkodama added the enhancement New feature or request label Nov 5, 2020
@Jellal-HT Jellal-HT self-assigned this Mar 10, 2022
@kathrynkodama kathrynkodama added 5 Estimated story points medium priority labels Aug 16, 2022
@kathrynkodama kathrynkodama added this to the EOY 2022 GA milestone Aug 24, 2022
@bensonnw
Copy link
Contributor

What dynamic templating are we looking for here? Current completionSnippets code is in LS side, there is no JDT information available, we need APIs to communicate with client.
There are many variables defined in JSON files, ${1:packagename}, ${2:path}, ${3:className}, ${4:methodname} etc. we only need to resolve package and class names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Estimated story points completion Completion item enhancement New feature or request medium priority snippet Snippet item
Projects
None yet
Development

No branches or pull requests

4 participants