Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter diagnostics based on classpath/imports #54

Closed
kathrynkodama opened this issue Nov 20, 2020 · 4 comments
Closed

Filter diagnostics based on classpath/imports #54

kathrynkodama opened this issue Nov 20, 2020 · 4 comments
Assignees
Labels
diagnostic Diagnostic item enhancement New feature or request EPIC high priority
Milestone

Comments

@kathrynkodama
Copy link
Contributor

kathrynkodama commented Nov 20, 2020

Possibly can use the JavaModelUtil.getClasspathEntry method

@kathrynkodama kathrynkodama added diagnostic Diagnostic item enhancement New feature or request labels Nov 20, 2020
@kathrynkodama
Copy link
Contributor Author

kathrynkodama commented Jul 26, 2022

Possible design decision around if we should show diagnostics if the API is not on the classpath, but it is clear they are intending to use that API given the import statements. We should compare to LSP4MP and JDT LS

In the below screenshot, we should not deliver the diagnostic on HelloServlet as the WebServlet import is incorect.
image

@kathrynkodama kathrynkodama changed the title Filter diagnostics based on classpath Filter diagnostics based on classpath/imports Jul 26, 2022
@bensonnw
Copy link
Contributor

bensonnw commented Aug 3, 2022

@kathrynkodama
Copy link
Contributor Author

kathrynkodama commented Aug 10, 2022

#159 looks related to Check interface hierarchy for Java class annotated by @WebListener also see the issues tagged project-info-needed Cannot be implemented until there is logic to get more information from the Java project

@bensonnw
Copy link
Contributor

Closing it as all PRs are merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic Diagnostic item enhancement New feature or request EPIC high priority
Projects
None yet
Development

No branches or pull requests

2 participants