Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jdk17 #279

Merged
merged 6 commits into from
Apr 2, 2024
Merged

use jdk17 #279

merged 6 commits into from
Apr 2, 2024

Conversation

Jad-el-khoury
Copy link
Contributor

Description

Migrate to JDK 17.

Checklist

  • This PR adds an entry to the CHANGELOG. _See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR expects some manual changes to the generated code. The needed changes are detailed in the CHANGELOG entry.
  • This PR was tested with at least one code generation, resulting in a working OSLC server.
  • This PR does NOT break the user block code

@Jad-el-khoury
Copy link
Contributor Author

The Jenkins configuration uses JDK 11 & maven 3.8.2.
We will need to update it to use JDK 17 & maven 3.9.6 (the latest available)

pom.xml Show resolved Hide resolved
@berezovskyi
Copy link
Contributor

I upgraded the JDK in GH actions but it's still using 3.8 Maven. I think the best is to upgrade the mvnw wrapper version and use that instead. Can you do it?

@berezovskyi
Copy link
Contributor

@Jad-el-khoury never mind, just fixed the build with JDK 21 and maven (wrapper) 3.9.6.

@Jad-el-khoury
Copy link
Contributor Author

@Jad-el-khoury never mind, just fixed the build with JDK 21 and maven (wrapper) 3.9.6.

@berezovskyi ! You have done quite an extensive set of changes on GH Actions. But we are still relying on Jenkins for Lyodesigner.
So, what's next?

  1. Update Jenkins?
  2. merge this PR?

@berezovskyi
Copy link
Contributor

@Jad-el-khoury I think we shall merge this PR and switch Jenkins to use JDK 17 and latest Maven. If latest Maven in Jenkins is not 3.9.6, then we should switch Jenkins from running mvn to ./mvnw as this PR did.

@Jad-el-khoury Jad-el-khoury merged commit a081e5d into master Apr 2, 2024
2 checks passed
@Jad-el-khoury Jad-el-khoury deleted the jdk17 branch April 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants