Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for sonarcloud bugs #942

Closed
wants to merge 18 commits into from
Closed

Fix for sonarcloud bugs #942

wants to merge 18 commits into from

Conversation

stefan-andritoiu
Copy link
Contributor

No description provided.

@alext-mkrs alext-mkrs self-requested a review December 23, 2018 20:07
alext-mkrs
alext-mkrs requested changes Dec 25, 2018
View reviewed changes
Copy link
Contributor

@alext-mkrs alext-mkrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but please see line comments for the first commit - we better split that one into three.

src/iio/iio.c Outdated Show resolved Hide resolved
src/iio/iio.c Show resolved Hide resolved
src/iio/iio.c Outdated Show resolved Hide resolved
src/iio/iio.c Show resolved Hide resolved
@adelindobre adelindobre force-pushed the sonarcloudbugs branch 3 times, most recently from 733c8b8 to e59ea9d Compare January 8, 2019 13:52
@cosmin-popescu cosmin-popescu force-pushed the sonarcloudbugs branch 2 times, most recently from fd90ffc to ebf83b8 Compare January 9, 2019 16:06
@cosmin-popescu
iio/iio.c: Add fix for division by 0 bug
69b119e 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
iio/iio.c: Add fix for access of variable before error check
0cd385c 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
iio/iio.c: Fix typo
2b3c202 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
x86/intel_galileo_rev_g.c: Removed switch break after return
45743b3 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
cosmin-popescu and others added 6 commits January 17, 2019 12:40
@cosmin-popescu
mraa.c: Add fix for potential memory leak
f79c3cf 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
gpio.c: Add fix for dereferencing of a null pointer
db476d6 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
mraa.c: Add fix for dereferencing of a null pointer
eaf792b 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@adelindobre @cosmin-popescu
initio.c: Add fix for passing null pointer as argument
5862699 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@adelindobre @cosmin-popescu
initio.c: Add fix for passing null as parameter
527f213 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@adelindobre @cosmin-popescu
initio.c: Add fix for potential leak memory
de72412 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@cosmin-popescu cosmin-popescu force-pushed the sonarcloudbugs branch 2 times, most recently from ee06367 to 018ddd4 Compare January 17, 2019 17:02
adelindobre and others added 7 commits January 17, 2019 19:04
@adelindobre @cosmin-popescu
examples/c++/uart.cpp: Add fix for potential memory leak
b921105 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@adelindobre @cosmin-popescu
jsonplatform.c: Add fix for dereferencing of a null pointer
e721717 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@adelindobre @cosmin-popescu
jsonplatform.c: Add fix for passing null as parameter
145d359 
Signed-off-by: Adelin Dobre <adelin.dobre@rinftech.com>
@cosmin-popescu
mraa.c: Fix memory leak
4d24d4d 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
gpio:c fix for gpio_group memory leak
f7327d8 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
gpio.c: Add fix for closing of uninitialzed fds
e8055d0 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
mraa:c Fix dereference of null pointer
270559c 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
@cosmin-popescu
initio.c: Fix for null pointer passed as parameter
eebe852 
Signed-off-by: Cosmin Popescu <gabrielcosmin.popescu@gmail.com>
alext-mkrs
alext-mkrs reviewed Feb 3, 2019
View reviewed changes
src/gpio/gpio.c
@@ -68,7 +68,10 @@ mraa_gpio_close_event_handles_sysfs(int fds[], int num_fds)
}

for (int i = 0; i < num_fds; ++i) {
close(fds[i]);
// Check required to avoid closing stdin and of an uninitialized fd
if(fds[i] != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't noticed this one before, sorry - please add a space between if and ( to align with mraa code style.

alext-mkrs
alext-mkrs requested changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@alext-mkrs alext-mkrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of new (or rather I haven't noticed them before) style-related comments and we're good to go.

src/json/jsonplatform.c
@@ -291,7 +291,11 @@ mraa_init_json_platform_i2c(json_object* jobj_i2c, mraa_board_t* board, int inde
json_object* jobj_temp = NULL;

// Default to no mux pins defined
board->pins[pin].i2c.mux_total = 0;
if(board->pins != NULL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't noticed this one before, sorry - please add a space between if and ( to align with mraa code style.

src/initio/initio.c
@@ -171,7 +171,7 @@ parse_uart(char** proto, size_t n, const char* proto_full)

/* Check for bytesize. */
int bytesize = -1;
if (mraa_atoi_x(proto[idx], &end, &bytesize, 0) != MRAA_SUCCESS) {
if (proto[idx] != NULL && mraa_atoi_x(proto[idx], &end, &bytesize, 0) != MRAA_SUCCESS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enough to use if (proto[idx] && <...>) as in other if statements here and elsewhere in the library - please align to that.

src/mraa.c
@@ -1374,10 +1374,13 @@ mraa_add_subplatform(mraa_platform_t subplatformtype, const char* dev)
return MRAA_ERROR_FEATURE_NOT_SUPPORTED;
}
int i2c_bus;
if(mraa_atoi(strdup(dev), &i2c_bus) != MRAA_SUCCESS && i2c_bus < plat->i2c_bus_count) {
char *dev_dup = strdup(dev);
if(mraa_atoi(dev_dup, &i2c_bus) != MRAA_SUCCESS && i2c_bus < plat->i2c_bus_count) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't noticed this one before, sorry - please add a space between if and ( to align with mraa code style.

@Propanu
Copy link
Contributor

Propanu commented Mar 7, 2019

Merged and ran clang-format address issues raised by @alext-mkrs. Thank you!

@Propanu Propanu closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alext-mkrs alext-mkrs alext-mkrs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefan-andritoiu @Propanu @alext-mkrs @cosmin-popescu @adelindobre