GH-8: As a smith I need two Xpect related files in N4JS repository #9
Conversation
Also-by: Moritz Eysholdt <moritz.eysholdt@typefox.io> Signed-off-by: Moritz Eysholdt <moritz.eysholdt@typefox.io>
|
@mor-n4 Sorry for assigning you again, that was a mouse-glitch... and I do not now how to take it back. @meysholdt Could you add your ok here as well? @mmews-n4 Removed Moritz sign-off -- we can only add him as "Also-by" |
| /** | ||
| * Explicitly request all expected items, as they may appear in scope only on explicit request. | ||
| */ | ||
| private void adaptActual(Iterable<?> actual, N4JSExpectationCollection exp, ActualCollection act) { |
There was a problem hiding this comment.
I believe this customization is technically not necessary, because it should be possible to wrap the logic from adaptActual() into a Predicate and call expectation.assertEquals(null, predicate). It's important that the first parameter is null, otherwise the predicate will only be used on Expectations containing a wildcard.
There was a problem hiding this comment.
This way the original CommaSeparatedValuesExpectation from Xpect could be used.
|
ok |
|
@meysholdt Thank you for your approval! We also think that we should refactor this. |
Task: #8
Also-by: Moritz Eysholdt moritz.eysholdt@typefox.io