Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename TR::ternary opcode to TR::select #681

Closed
fjeremic opened this issue Jan 18, 2017 · 7 comments · Fixed by #4865
Closed

Rename TR::ternary opcode to TR::select #681

fjeremic opened this issue Jan 18, 2017 · 7 comments · Fixed by #4865
Labels
architecture review OK backlog comp:compiler good first issue help wanted

Comments

@fjeremic
Copy link
Contributor

As per the discussion in #668 and the subsequent answer by @andrewcraik (#668 (comment)) it seems the TR::ternary IL opcode is slightly misleading to ignorant developers such as myself.

We should document that the semantics of this IL opcode are that all children will be evaluated and executed, and hence the children should have no side-effects should you try to emulate the canonical meaning of a ternary operator in many languages (:?).

An alternative here would be to rename the opcode all together to avoid the confusion.
@mgaudet
Copy link

mgaudet commented Jan 19, 2017

I would vote on rename-- it is too useful to get rid of in my opinion.

TR::select?

@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 3, 2017

Given only opinions in favour of renaming, the TR::ternary IL opcode shall be renamed to TR::select. Some documentation describing its behaviour is in order as well.

@0xdaryl 0xdaryl changed the title Document or rename TR::ternary IL opcode Rename TR::ternary opcode to TR::select Jul 22, 2017
@alvee-unb
Copy link
Contributor

I am renaming all the variables such as- TR::bternary, TR::sternary etc. to TR::bselect, TR::sselect etc. respectively. Also renaming the other functions those were named depending on these variables such as- bternaryEvaluator etc. to bselectEvaluator etc. including all such comments.

@0xdaryl
Copy link
Contributor

0xdaryl commented Sep 19, 2019 •
edited
Loading

Although this issue predates the Compiler Architecture Meetings and the current standard for community review for new opcodes (or changes to existing opcodes), I would like to tag this one for discussion at the next CAM in case there are any concerns. Prior to that, if anyone has any concerns or comments please bring that up in this PR.

@aarongraham9
Copy link
Contributor

Sounds good @0xdaryl, thanks!

@alvee-unb
Copy link
Contributor

alvee-unb commented Sep 20, 2019 •
edited
Loading

Thanks @0xdaryl , can you please also let me know whether the following changes are needed for the components in the respective files (and more)-

~/omr/compiler/aarch64/codegen/OMRTreeEvaluator.hpp

  • vternaryEvaluator

~/omr/compiler/codegen/CodeGenPrep.cpp

  • >rematerializeCmpUnderTernary

~/omr/compiler/il/OMRIL.cpp

  • opCodesForTernarySelect

~/omr/compiler/il/OMRILOpCodeProperties.hpp

  • ILProp2::Ternary
  • TR::vternary

~/omr/compiler/il/OMRNode.cpp

  • ternarySeenCollected

We can discuss more on the next CAM.

@0xdaryl 0xdaryl mentioned this issue Sep 25, 2019
Closed
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 20, 2019
@alvee-unb
Refactoring One- TR::ternary opcodes to TR::select
b0f01c7 
Part one of the iterations to replace the ternary OpCodes such as
TR::bternary etc. to TR::bselect etc.respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc..
- Corresponding outputs of texts such as- "iselect"

Partially Resolves: GitHub issue eclipse-omr#681

Signed-off-by: mnoor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 20, 2019
@alvee-unb
Refactoring Two- TR::ternary opcodes to TR::select
794db7a 
Part two of the iterations to replace the ternary OpCodes such as
TR::bternary etc. to TR::bselect etc.respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double etc.
  (iternary, vternary, iuternary etc)
- Corresponding comments where the above changes are made
- Corresponding outputs of texts such as- "iselect" etc.

Partially Resolves: GitHub issue eclipse-omr#681

Signed-off-by: mnoor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 20, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
17a3090 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).

Closes: GitHub issue eclipse-omr#681

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
@alvee-unb alvee-unb mentioned this issue Nov 20, 2019
Merged
@alvee-unb alvee-unb mentioned this issue Nov 20, 2019
Merged
@alvee-unb
Copy link
Contributor

I have done the requested changes and would appreciate the review. Thank you.

alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 25, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
c90236d 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.

Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 25, 2019
@alvee-unb
Refactoring One- TR::ternary opcodes to TR::select
7a83f92 
Part one of the iterations to replace the ternary OpCodes such as
TR::bternary etc. to TR::bselect etc.respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc..
- Corresponding outputs of texts such as- "iselect"

Partially Resolves: GitHub issue eclipse-omr#681

Signed-off-by: mnoor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 25, 2019
@alvee-unb
Refactoring Two- TR::ternary opcodes to TR::select
226117b 
Part two of the iterations to replace the ternary OpCodes such as
TR::bternary etc. to TR::bselect etc.respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double etc.
  (iternary, vternary, iuternary etc)
- Corresponding comments where the above changes are made
- Corresponding outputs of texts such as- "iselect" etc.

Partially Resolves: GitHub issue eclipse-omr#681

Signed-off-by: mnoor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Nov 25, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
9ca7659 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.

Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
@alvee-unb alvee-unb mentioned this issue Nov 25, 2019
Closed
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Dec 16, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
e8f48d1 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating the class names.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Dec 16, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
3948cd5 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating the class names.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Dec 20, 2019
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
097199d 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Jan 14, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
4d02352 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Jan 14, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
1ad446f 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 12, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
62e6925 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 19, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
e10c9e0 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
@alvee-unb alvee-unb mentioned this issue Feb 19, 2020
Closed
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 25, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
66aae96 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 25, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
4eea71b 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 25, 2020
@alvee-unb
Cleaning up duplicated code
cb88d4d 
Removed deprecated functions (i.e. `getSupportsTernary` etc.)
which were introduced by the PR eclipse-omr#4578.

Closes: GitHub issue eclipse-omr#681

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
@alvee-unb alvee-unb mentioned this issue Feb 25, 2020
Merged
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Feb 25, 2020
@alvee-unb
Cleaning up duplicated code
fae0f8c 
Removed deprecated functions (i.e. `getSupportsTernary` etc.)
which were introduced by the PR eclipse-omr#4578.

Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4847

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
AlenBadel pushed a commit to AlenBadel/omr that referenced this issue Feb 29, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
6af06d1 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/openj9 that referenced this issue Mar 2, 2020
@alvee-unb
Refactoring of TR::ternary opcodes to TR::select
f596aea 
Replaced the ternary OpCodes such as TR::aternary etc. to
TR::aselect etc. respectively.

Related OMR PR: eclipse-omr/omr#4578

Partially Resolves: Issue eclipse-omr/omr#681 and eclipse-omr/omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb added a commit to CAS-Atlantic/omr that referenced this issue Mar 3, 2020
@alvee-unb
Cleaning up duplicated code
55e29bd 
Removed deprecated functions (i.e. `getSupportsTernary` etc.)
which were introduced by the PR eclipse-omr#4578.

Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4847

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
PushkarBettadpur pushed a commit to PushkarBettadpur/omr that referenced this issue Mar 13, 2020
@alvee-unb @PushkarBettadpur
Refactoring of TR::ternary opcodes to TR::select
97e7fbd 
Replacing of the ternary OpCodes such as TR::bternary etc. to
TR::bselect etc. and the associated items respectively.

The changes are made onto the followings:
- Components of various data types such as- Int8, Float, Double
  (iternary, bternary, vternary etc) etc..
- Corresponding evaluators such as- bselectEvaluator, iselectEvaluator
  etc. and other functions where the IL OpCodes are used.
- Corresponding outputs of texts such as- "iselect" etc. and comments
  (//ternary).
- The IL opcode (and its respective evaluator to- vbitselectEvaluator)-
vselect has been updated to vbitselect.
- The new vselect opcode has been marked- unimplemented in the Z tree
evaluator.
- File names which involved updating of the class names.
- There are some duplicated usages of the opcodes (`aternary`) and
their respective functions for their dependencies on OpenJ9, they will
need to be deleted once the eclipse/openj9 #7797 PR is accepted.

Partially Resolves: GitHub issues eclipse-omr#681 and eclipse-omr#4590

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
PushkarBettadpur pushed a commit to PushkarBettadpur/omr that referenced this issue Mar 13, 2020
@alvee-unb @PushkarBettadpur
Cleaning up duplicated code
719d969 
Removed deprecated functions (i.e. `getSupportsTernary` etc.)
which were introduced by the PR eclipse-omr#4578.

Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4847

Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture review OK backlog comp:compiler good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ternary to select cleanup CAS-Atlantic/omr
5 participants
@aarongraham9 @mgaudet @fjeremic @0xdaryl @alvee-unb