Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TR::InstOpCode helper #2656

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

dhong44
Copy link
Contributor

@dhong44 dhong44 commented Jun 8, 2018

Add a missing TR::InstOpCode helper for Z.
The missing helper is add logical immediate and
returns ALGFI on 64 bit and ALFI on 32 bit computers.

Signed-off-by: Daniel Hong daniel.hong@live.com

Add a missing TR::InstOpCode helper for Z.
The missing helper is add logical immediate and
returns ALGFI on 64 bit and ALFI on 32 bit computers.

Signed-off-by: Daniel Hong <daniel.hong@live.com>
@dhong44
Copy link
Contributor Author

dhong44 commented Jun 8, 2018

@fjeremic Could I get a review please

@dhong44 dhong44 changed the title Add missing TR::InstOpCode helper WIP: Add missing TR::InstOpCode helper Jun 8, 2018
@fjeremic fjeremic self-assigned this Jun 8, 2018
@fjeremic
Copy link
Contributor

fjeremic commented Jun 8, 2018

@dhong44 I'll merge if builds pass and WIP: is removed.

@genie-omr build zlinux,zos

@dhong44 dhong44 changed the title WIP: Add missing TR::InstOpCode helper Add missing TR::InstOpCode helper Jun 11, 2018
@fjeremic fjeremic merged commit d656eff into eclipse-omr:master Jun 11, 2018
@dhong44 dhong44 deleted the addOpCodeHelper branch June 11, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants