Refactor ternary to select cleanup #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvee-unb
requested review from
0xdaryl,
andrewcraik,
charliegracie,
fjeremic,
Leonardo2718,
mstoodle,
rwy7,
vijaysun-omr and
youngar
as code owners
alvee-unb
force-pushed
the
Refactor-TernaryToSelect-Cleanup
branch
from
cb88d4d
to
fae0f8c
Compare
alvee-unb
changed the title
Removed deprecated functions (i.e. `getSupportsTernary` etc.) which were introduced by the PR eclipse-omr#4578. Closes: GitHub issue eclipse-omr#681 and eclipse-omr#4847 Signed-off-by: Md. Alvee Noor <mnoor@unb.ca>
alvee-unb
force-pushed
the
Refactor-TernaryToSelect-Cleanup
branch
from
fae0f8c
to
55e29bd
Compare
|
@genie-omr build all |
|
AIX CI tests appear to pass, but fail afterwards for an infrastructural issue. Merging. |
0xdaryl
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up duplicated code
Removed deprecated functions (i.e.
getSupportsTernaryetc.)which were introduced by the PR #4578.
Closes: #681 and #4847