Fix DDR field inconsistency in mixed refs builds #5758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
requested review from
charliegracie,
rwy7 and
youngar
as code owners
This was referenced Jan 19, 2021
gacholio
approved these changes
Jan 19, 2021
keithc-ca
reviewed
Jan 19, 2021
keithc-ca
reviewed
Jan 19, 2021
keithc-ca
reviewed
Jan 19, 2021
keithc-ca
reviewed
Jan 19, 2021
Remove !defined(OMR_OVERRIDE_COMPRESS_OBJECT_REFERENCES) from preprocessor guard of _compressObjectReferences field Make _compressObjectReferences a protected field Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
sharon-wang
force-pushed
the
corprotected
branch
from
b91ffcb
to
4752253
Compare
|
I've run these changes against the failing tests and they are now passing. |
keithc-ca
approved these changes
Jan 20, 2021
|
@dmitripivkine Could you please review? |
dmitripivkine
approved these changes
Jan 20, 2021
|
@fjeremic This should be ready to build! |
|
@genie-omr build all |
|
@fjeremic looks like this is good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: eclipse-openj9/openj9#11469
OpenJ9 equivalent changes: eclipse-openj9/openj9#11691
!defined(OMR_OVERRIDE_COMPRESS_OBJECT_REFERENCES)from preprocessor guard of_compressObjectReferencesfield_compressObjectReferencesaprotectedfield in header files that declare it -- keeping it as a private field while removing the OVERRIDE check causes clang to error on osx (-Wunused-private-field)Related: eclipse-openj9/openj9#8878, eclipse-openj9/openj9#11166