VerboseGC Initialized Stanza Print Fix #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `printf` methods _(e.g `omrfile_printf` & `omrfilestream_printf`)_ to write to files is problematic when the output buffer contains a string with a specifier character (e.g %s). In such a case, the special character is intended to be be outputted raw to the file rather than evaluated/expanded. `printf` will attempt to evaluate the specifiers whereas the buffer must be printed raw. Currently, `printf` methods are used when outputting verbose initialized block (string). When outputting the init block, use the verbose writer's `outputString` method rather than using - `omrfilestream_printf` for FileLoggingSynchronous Writer - `omrfile_printf` for FileLoggingBuffered Writer `outputString` will use `omrfile_write_text` and just print the raw characters. Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman
requested review from
charliegracie,
rwy7 and
youngar
as code owners
amicic
approved these changes
Feb 10, 2021
|
@fjeremic could you please have a look whenever you have some time. Ideally, we'd like the fix in by the end of day |
fjeremic
approved these changes
Feb 10, 2021
|
@genie-omr build all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
printfmethods to write to files (e.gomrfile_printf&omrfilestream_printf) is problematic when the output buffer contains a string with specifier characters (e.g %s). In such a case, the format specifiers are intended to be outputted raw to the file rather than evaluated/expanded.printfwill treat the string as a format string and attempt to evaluate the specifiers (and crash) whereas the buffer must be printed raw. Currently,printfmethods are used when outputting verbose initialized block (string).When outputting the init block, use the verbose writer's
outputStringmethod rather than usingomrfilestream_printffor FileLoggingSynchronous Writeromrfile_printffor FileLoggingBuffered WriteroutputStringwill useomrfile_write_textand just print the raw characters.Signed-off-by: Salman Rana salman.rana@ibm.com